Fix GH-14874: report correct line for property/const variance errors#57
Closed
Fix GH-14874: report correct line for property/const variance errors#57
Conversation
iliaal
force-pushed
the
fix/gh-14874-property-const-variance-lineno
branch
2 times, most recently
from
fbfd02a to
d407cc1
Compare
Add a uint32_t line field to zend_property_info and zend_class_constant, populated from the AST node lineno at compile time. The variance emitters route through zend_error_at_noreturn so the error points at the offending child member rather than the class declaration. Members left at line 0 (internal classes, trait-copied properties) fall back to zend_error_noreturn (legacy behavior, no regression). Fixes phpGH-14874
iliaal
force-pushed
the
fix/gh-14874-property-const-variance-lineno
branch
from
d407cc1 to
4525613
Compare
Owner
Author
|
Submitted upstream as php#21993. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes php#14874. Adds a
uint32_t linefield tozend_property_infoandzend_class_constantcaptured from the AST node, so the variance emitters route throughzend_error_at_noreturnand point at the offending child member. Members left at line 0 (internal classes, trait-copied properties) fall back to the legacy emitter.